Add constantine to important_packages.nim #23801

mratsim · 2024-07-06T07:27:23Z

This adds Constantine to the important packages. Release announcements:

Unfortunately at the moment I'm in a conundrum.

Constantine cannot compile on devel due to Semi-regression (?): generic typeclass not matching #23547
The workaround is changing
```
func mulCheckSparse*(a: var QuadraticExt, b: static QuadraticExt) {.inline.} =
```
to
```
template mulCheckSparse*(a: var QuadraticExt, b: QuadraticExt) =
```
but this does not compile on v2.0.8 due to gensym issues despite [backport] fixes #23711; C code contains backtick`gensym #23716
.
i.e. as mentioned in the issue [Semi-regression] C code contains backtick`gensym #23711 there is another gensym bug within templates that was fixed in devel but not the v2.0.x series and that is not fixed by [backport] fixes #23711; C code contains backtick`gensym #23716

mratsim · 2024-07-17T13:09:16Z

Following mratsim/constantine#434 it should work on all v1.6.x, v2.0.x and devel

mratsim · 2024-07-17T16:56:06Z

This is now passing tests, the failure is unrelated (chronos)

github-actions · 2024-07-17T17:09:38Z

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from ddb31ce

Hint: mm: orc; opt: speed; options: -d:release
173156 lines; 8.509s; 664.078MiB peakmem

mratsim added 2 commits July 6, 2024 09:19

Add constantine to important_packages.nim

a3fe7c7

Merge branch 'devel' into important-packages-constantine

4db52b8

mratsim marked this pull request as ready for review July 17, 2024 13:08

mratsim closed this in mratsim/constantine@9bf1232 Jul 17, 2024

mratsim reopened this Jul 17, 2024

Araq merged commit ddb31ce into devel Jul 17, 2024
26 of 27 checks passed

Araq deleted the important-packages-constantine branch July 17, 2024 17:04

Provide feedback